Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coturn cert-reloader sidecar config: process name should not contain the path (helm chart) #3916

Merged
merged 2 commits into from
Mar 4, 2024
Merged

coturn cert-reloader sidecar config: process name should not contain the path (helm chart) #3916

merged 2 commits into from
Mar 4, 2024

Conversation

mastaab
Copy link
Contributor

@mastaab mastaab commented Mar 4, 2024 •
edited by akshaymankar
Loading

The sidecar only looks for the process name.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 4, 2024
akshaymankar
akshaymankar approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mastaab mastaab merged commit b93a24f into develop Mar 4, 2024
8 checks passed
@mastaab mastaab deleted the WPB-6567-Coturn-certificate-reloader-sidecar-not-working-as-designed branch March 4, 2024 10:21
@mastaab mastaab restored the WPB-6567-Coturn-certificate-reloader-sidecar-not-working-as-designed branch March 5, 2024 15:42
@mastaab mastaab deleted the WPB-6567-Coturn-certificate-reloader-sidecar-not-working-as-designed branch March 6, 2024 09:17
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mastaab @CLAassistant @akshaymankar @zebot