Update http2, wai. #3911
Merged
Update http2, wai. #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
elland
force-pushed
the
connection-is-closed
branch
from
44fb140 to
e516c0d
Compare
MangoIV
reviewed
Mar 4, 2024
elland
force-pushed
the
connection-is-closed
branch
2 times, most recently
from
265e853 to
a8e8d08
Compare
MangoIV
approved these changes
Mar 5, 2024
elland
force-pushed
the
connection-is-closed
branch
4 times, most recently
from
95dde02 to
789c2a3
Compare
MangoIV
approved these changes
Mar 5, 2024
Comment on lines
+271
to
+274
| allocServerConfig :: (Socket, Maybe SSL.SSL) -> IO Server.Config | ||
| allocServerConfig (sock, Nothing) = | ||
| HTTP2.allocSimpleConfig sock 4096 | ||
| allocServerConfig (sock, Just ssl) = do |
There was a problem hiding this comment.
nit: perhaps this would be nicer curried.
| | chunkLen > n -> | ||
| error "openssl: SSL.read returned more bytes than asked for, this is probably a bug" | ||
| | otherwise -> | ||
| readData (prevChunk <> chunk) (n - chunkLen) | ||
|
|
||
| testServerOnSocket :: Maybe SSL.SSLContext -> Socket -> IORef Int -> IORef (Map Unique (Async ())) -> IO () | ||
| testServerOnSocket mCtx listenSock connsCounter conns = do | ||
| listen listenSock 1024 | ||
| forever $ do | ||
| (sock, _) <- accept listenSock | ||
| serverCfgParam <- case mCtx of |
There was a problem hiding this comment.
in that case you could just match here directly and then only pass the snd to the case
elland
force-pushed
the
connection-is-closed
branch
6 times, most recently
from
c28ca13 to
872ccb7
Compare
MangoIV
reviewed
Mar 7, 2024
elland
force-pushed
the
connection-is-closed
branch
3 times, most recently
from
ee9965a to
b92cdb0
Compare
MangoIV
approved these changes
Mar 7, 2024
elland
force-pushed
the
connection-is-closed
branch
from
4ec8059 to
3b076e4
Compare
fisx
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may also fix https://wearezeta.atlassian.net/browse/WPB-5357
This cleans up the
ConnectionIsClosednoise.