-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ejpd data model exhaustive #3875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44a8377
to
7232c16
Compare
8b7344d
to
85bb079
Compare
610c61e
to
8e751ff
Compare
b3c5f18
to
cf6a7dc
Compare
431a46f
to
354e5b7
Compare
354e5b7
to
eca4fb5
Compare
battermann
approved these changes
Mar 12, 2024
Comment on lines
+24
to
+37
EJPDResponseItem | ||
( EJPDResponseItem, | ||
ejpdResponseUserId, | ||
ejpdResponseTeamId, | ||
ejpdResponseName, | ||
ejpdResponseHandle, | ||
ejpdResponseEmail, | ||
ejpdResponsePhone, | ||
ejpdResponsePushTokens, | ||
ejpdResponseContacts, | ||
ejpdResponseTeamContacts, | ||
ejpdResponseConversations, | ||
ejpdResponseAssets | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
EJPDResponseItem | |
( EJPDResponseItem, | |
ejpdResponseUserId, | |
ejpdResponseTeamId, | |
ejpdResponseName, | |
ejpdResponseHandle, | |
ejpdResponseEmail, | |
ejpdResponsePhone, | |
ejpdResponsePushTokens, | |
ejpdResponseContacts, | |
ejpdResponseTeamContacts, | |
ejpdResponseConversations, | |
ejpdResponseAssets | |
), | |
EJPDResponseItem (..) |
not very important, though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6329
Checklist
changelog.d