Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: Make tests pass by increasing http2-max-requests in the ingress controller #3787

Closed
wants to merge 1 commit into from
Closed

hack: Make tests pass by increasing http2-max-requests in the ingress controller #3787

wants to merge 1 commit into from

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Dec 18, 2023 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-5934

Workaround for: kazu-yamamoto/http2#102

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d No changelog.
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 18, 2023
@akshaymankar akshaymankar changed the title hack: Make tests pass by increasing keepalive_requests for federator ingress hack: Make tests pass by increasing http2-max-requests in ingress-nginx Dec 19, 2023
@akshaymankar akshaymankar changed the title hack: Make tests pass by increasing http2-max-requests in ingress-nginx hack: Make tests pass by increasing http2-max-requests in the ingress controller Dec 19, 2023
mdimjasevic
mdimjasevic approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about YAML templating, but why is the limit in one place in quotes and not in the other?

@akshaymankar
Copy link
Member Author

superseded by #3789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @mdimjasevic @zebot