-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-5389] Guard user connection requests by team-level federation settings #3774
Merged
mdimjasevic
merged 27 commits into
develop
from
wpb-5389/team-federation-connection-requests
Dec 18, 2023
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1bf760a
Define the new user connection request error
mdimjasevic 77dbb28
An effect utility to check team federation
mdimjasevic 40af043
Perform team federation checks on the calling side
mdimjasevic 025ee87
Formatting the code
mdimjasevic 0944177
Introduce 1-1 conv test setup helpers
mdimjasevic 2263d76
Test: Migrate "Remote connections: mutual Connect - local action then…
mdimjasevic 735c8e1
Test: Migrate "Remote connections: mutual Connect - remote action the…
mdimjasevic 64a8831
[feat] move testRemoteUserGetsDeleted to new integration testsuite
MangoIV 326d078
Test utility to assert on connection status
mdimjasevic 19103cb
Test: Migrate "Remote connections: ignore then accept"
mdimjasevic 0753614
Test: Migrate "Remote connections: ignore, remote cancels, then accept"
mdimjasevic 974d2ac
Test: Migrate "Remote connections: block then accept"
mdimjasevic 71a3aa5
Test: Migrate "Remote connections: block, remote cancels, then accept"
mdimjasevic 22b6119
Test: Migrate "Remote connections: send then cancel"
mdimjasevic 3334e14
[feat] move testInternalGetConStatusesAll to new testsuite
MangoIV e969c4a
Include the team ID in the fed connection request
mdimjasevic 2d3b0cd
[feat] move testConnectionLimits to new integration test suite
MangoIV 5ecfbff
Revert the generalisation of 'ensureFederatesWith'
mdimjasevic afe5585
[fix] comment back in test that is still broken
MangoIV 73aaf60
Test: not federating with a remote team
mdimjasevic 64a6764
Test: connection attempt under non-mutual federation
mdimjasevic bf9cd5f
Test: connect under allow-all mutual federation
mdimjasevic baecae3
Test: connect under allow-dynamic mutual federation
mdimjasevic 4428ca6
Test: connect under mixed federation-allow policies
mdimjasevic e39b56f
Add a changelog
mdimjasevic 8cc26cb
Remove an unused fed client argument in tests
mdimjasevic 2818183
fixup! Introduce 1-1 conv test setup helpers
mdimjasevic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
changelog.d/2-features/WPB-5389-team-level-federation-guarded-user-connections
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Apply team-level federation policies when establishing and updating user connections |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,7 @@ library | |
Test.B2B | ||
Test.Brig | ||
Test.Client | ||
Test.Connection | ||
Test.Conversation | ||
Test.Demo | ||
Test.Errors | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could imagine, that if this gets reused by other tests in the future, that the caller would want to provide both the domains with support for the dynamic backends as well. But then again, this can be added when needed. So all good.