Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify federation diagram to include rabbitmq: updating the diagram and the source file #3739

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Modify federation diagram to include rabbitmq: updating the diagram and the source file #3739

merged 2 commits into from
Jan 31, 2024

Conversation

arthurwolf
Copy link
Contributor

@arthurwolf arthurwolf commented Nov 23, 2023 •
edited
Loading

see wpb-3933

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 23, 2023
akshaymankar
akshaymankar requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few incorrect things:

  • Federator doesn't talk to rabbitmq, brig and galley do.
  • Notification pusher talks to federator, it never talks outside the box.
  • Cargohold is missing from this. It talks to federator and federator talks to it just like brig and galley. It doesn't talk to rabbitmq.

@arthurwolf
Copy link
Contributor Author

federated-backend-architecture

preview of latest version after two rounds of Akshay comments.

@mastaab mastaab requested a review from akshaymankar January 3, 2024 12:38
akshaymankar
akshaymankar approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 🚀

@arthurwolf arthurwolf merged commit 761fee8 into develop Jan 31, 2024
1 check passed
@arthurwolf arthurwolf deleted the wpb-3933-update-federated-diagram-for-rabbitmq branch January 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurwolf @akshaymankar @zebot