Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire-server chart: Disable integration chart by default #3682

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Oct 31, 2023

Fixup to #3171. This PR updates the wire-server chart so that it doesn't include the integration chart by default.
Without this PR the integration chart is installed, which creates an superfluous kubernetes objects, including an (internal) ingress for a subdomain of svc.cluster.local.

Disabling works because of this tag

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 31, 2023
@smatting smatting requested a review from supersven October 31, 2023 16:27
@smatting smatting force-pushed the integration-disable-by-default branch from e472840 to 1d5ce2f Compare April 8, 2024 09:45
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(Let's wait for the CI before merging.)

@smatting smatting merged commit b23f4db into develop Apr 8, 2024
8 checks passed
@smatting smatting deleted the integration-disable-by-default branch April 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants