-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress buffer error for mls decrypt transaction [WPB-16233] #3305
fix: suppress buffer error for mls decrypt transaction [WPB-16233] #3305
Conversation
Test Results3 367 tests 3 257 ✅ 5m 32s ⏱️ Results for commit a955880. ♻️ This comment has been updated with latest results. |
cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 3257 Passed, 110 Skipped, 1m 3.27s Total Time |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3305 +/- ##
====================================================
Coverage ? 54.54%
====================================================
Files ? 1252
Lines ? 36684
Branches ? 3740
====================================================
Hits ? 20008
Misses ? 15253
Partials ? 1423 Continue to review full report in Codecov by Sentry.
|
…3305) * fix: suppress buffer error for mls decrypt transaction * detekt fix * error check fix * detekt fix
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
BufferedFutureMessage
exception instead of buffering and persisting the message.Causes
MlsException.BufferedFutureMessage
(wrapped inCoreCryptoException.Mls
) within the transactional decryption flow.Solutions
decryptMessage
flow to wrap calls in a transactional API and specifically catchBufferedFutureMessage
exceptions, allowing the transaction to commit and the message to be buffered rather than rolled back.