Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recover when getting error for updating connection status [WPB-16146] #3297

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 18, 2025

BugWPB-16146 [Android]Existing connection resets to pending state after adding user to conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

a broken connection request can never be restored

Solutions

when updating a connection and getting 403 with bac_conn_update then recover by calling the backend to get the updated status of this request

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title fix: recover when getting error for updating connection status fix: recover when getting error for updating connection status [WPB-16146] Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Test Results

3 361 tests  +1   3 253 ✅ +1   5m 11s ⏱️ -16s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit a0e2c09. ± Comparison against base commit 86dc0f7.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (d2d82b8) to head (a0235ad).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...um/network/api/v0/authenticated/ConnectionApiV0.kt 0.00% 3 Missing ⚠️
...lium/logic/data/connection/ConnectionRepository.kt 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3297      +/-   ##
=====================================================
+ Coverage              54.53%   54.54%   +0.01%     
=====================================================
  Files                   1252     1252              
  Lines                  36669    36684      +15     
  Branches                3737     3740       +3     
=====================================================
+ Hits                   19997    20009      +12     
- Misses                 15251    15253       +2     
- Partials                1421     1422       +1     
Files with missing lines Coverage Δ
.../wire/kalium/network/exceptions/KaliumException.kt 78.94% <100.00%> (+0.37%) ⬆️
...ire/kalium/network/exceptions/NetworkErrorLabel.kt 100.00% <ø> (ø)
...lium/logic/data/connection/ConnectionRepository.kt 66.91% <92.30%> (+2.16%) ⬆️
...um/network/api/v0/authenticated/ConnectionApiV0.kt 71.42% <0.00%> (-11.91%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d82b8...a0235ad. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 18, 2025

Datadog Report

Branch report: fix/recover-when-getting-error-for-updating-connection-status
Commit report: 8adbb18
Test service: kalium-jvm

✅ 0 Failed, 3253 Passed, 108 Skipped, 1m 0.84s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 20, 2025
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to the queue being cleared Feb 20, 2025
@MohamadJaara MohamadJaara merged commit 7baa25a into release/candidate Feb 20, 2025
8 checks passed
@MohamadJaara MohamadJaara deleted the fix/recover-when-getting-error-for-updating-connection-status branch February 20, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants