-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recover when getting error for updating connection status [WPB-16146] #3297
fix: recover when getting error for updating connection status [WPB-16146] #3297
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3297 +/- ##
=====================================================
+ Coverage 54.53% 54.54% +0.01%
=====================================================
Files 1252 1252
Lines 36669 36684 +15
Branches 3737 3740 +3
=====================================================
+ Hits 19997 20009 +12
- Misses 15251 15253 +2
- Partials 1421 1422 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3253 Passed, 108 Skipped, 1m 0.84s Total Time |
…for-updating-connection-status
…for-updating-connection-status
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
a broken connection request can never be restored
Solutions
when updating a connection and getting 403 with
bac_conn_update
then recover by calling the backend to get the updated status of this requestDependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.