-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move either/flow to common module (#WPB-16073) #3291
Conversation
|
Branch | kalium-refactoring |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 683.85 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 401,007.42 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,341,787.91 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,790.61 |
Datadog ReportBranch report: ✅ 0 Failed, 3411 Passed, 108 Skipped, 1m 0.14s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3291 +/- ##
===========================================
- Coverage 50.88% 50.69% -0.19%
===========================================
Files 1606 1611 +5
Lines 58058 58102 +44
Branches 5204 5218 +14
===========================================
- Hits 29541 29454 -87
- Misses 26502 26640 +138
+ Partials 2015 2008 -7 see 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
81fd156
to
563222c
Compare
|
@@ -94,7 +94,7 @@ internal class ConversationFolderDataSource internal constructor( | |||
.flatMapLeft { | |||
if (it is NetworkFailure.ServerMiscommunication | |||
&& it.kaliumException is KaliumException.InvalidRequestError | |||
&& it.kaliumException.errorResponse.code == HttpStatusCode.NotFound.value | |||
&& (it.kaliumException as KaliumException.InvalidRequestError).errorResponse.code == HttpStatusCode.NotFound.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit annoying, but necessary :(
https://wearezeta.atlassian.net/browse/WPB-16073
What's new in this PR?
Issues
It is not possible to create "feature-modules" in kalium since some of the base classes are defined as internal in the
kalium:logic
module.Solutions
kalium:common
moduleCoreLogger
to the common moduleCoreFailure
to the common module