Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move either/flow to common module (#WPB-16073) #3291

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 11, 2025

TaskWPB-16073 [Android] Kalium refactoring

https://wearezeta.atlassian.net/browse/WPB-16073

What's new in this PR?

Issues

It is not possible to create "feature-modules" in kalium since some of the base classes are defined as internal in the kalium:logic module.

Solutions

  • Created new kalium:common module
  • Moved 'logic.functional` package to a new common module
  • Moved CoreLogger to the common module
  • Moved CoreFailure to the common module

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Test Results

3 519 tests  ±0   3 411 ✅ ±0   6m 6s ⏱️ -6s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit 563222c. ± Comparison against base commit 243726b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 11, 2025

Datadog Report

Branch report: kalium-refactoring
Commit report: 9f8521b
Test service: kalium-jvm

✅ 0 Failed, 3411 Passed, 108 Skipped, 1m 0.14s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.69%. Comparing base (243726b) to head (563222c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3291      +/-   ##
===========================================
- Coverage    50.88%   50.69%   -0.19%     
===========================================
  Files         1606     1611       +5     
  Lines        58058    58102      +44     
  Branches      5204     5218      +14     
===========================================
- Hits         29541    29454      -87     
- Misses       26502    26640     +138     
+ Partials      2015     2008       -7     

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243726b...563222c. Read the comment docs.

@vitorhugods vitorhugods changed the title feat: move either/flow to common module (#WPB-16073) refactor: move either/flow to common module (#WPB-16073) Feb 12, 2025
@@ -94,7 +94,7 @@ internal class ConversationFolderDataSource internal constructor(
.flatMapLeft {
if (it is NetworkFailure.ServerMiscommunication
&& it.kaliumException is KaliumException.InvalidRequestError
&& it.kaliumException.errorResponse.code == HttpStatusCode.NotFound.value
&& (it.kaliumException as KaliumException.InvalidRequestError).errorResponse.code == HttpStatusCode.NotFound.value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit annoying, but necessary :(

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Feb 12, 2025
Merged via the queue into develop with commit 4417365 Feb 12, 2025
28 checks passed
@sbakhtiarov sbakhtiarov deleted the kalium-refactoring branch February 12, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants