Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: return specialized result and error handling for GetLoginFlowForDomainUseCase (WPB-15520) #3289

Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 11, 2025

TaskWPB-15520 [Android] - Implement error handling for initial screens


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Returns Result instead of Either
  • Creates specialized errors for proper handling
  • Test coverage

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Test Results

3 437 tests   3 329 ✅  5m 44s ⏱️
  590 suites    108 💤
  590 files        0 ❌

Results for commit a14dee2.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina changed the title refactor: returns specialized result and error handling in GetLoginFlowForDomainUseCase (WPB-15520) refactor: return specialized result and error handling for GetLoginFlowForDomainUseCase (WPB-15520) Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 76.08696% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (epic/new-sso-login-flow@197a6e9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/kalium/logic/feature/auth/LoginRedirectMapper.kt 25.00% 5 Missing and 1 partial ⚠️
...ire/kalium/logic/feature/auth/LoginRedirectPath.kt 50.00% 3 Missing ⚠️
...e/kalium/logic/feature/auth/AuthenticationScope.kt 0.00% 1 Missing ⚠️
...logic/feature/auth/GetLoginFlowForDomainUseCase.kt 96.55% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             epic/new-sso-login-flow    #3289   +/-   ##
==========================================================
  Coverage                           ?   54.00%           
==========================================================
  Files                              ?     1322           
  Lines                              ?    37623           
  Branches                           ?     3794           
==========================================================
  Hits                               ?    20320           
  Misses                             ?    15880           
  Partials                           ?     1423           
Files with missing lines Coverage Δ
...kalium/logic/data/auth/DomainRegistrationMapper.kt 60.00% <ø> (ø)
...com/wire/kalium/logic/data/auth/LoginDomainPath.kt 83.33% <100.00%> (ø)
...e/kalium/logic/feature/auth/AuthenticationScope.kt 0.00% <0.00%> (ø)
...logic/feature/auth/GetLoginFlowForDomainUseCase.kt 97.56% <96.55%> (ø)
...ire/kalium/logic/feature/auth/LoginRedirectPath.kt 50.00% <50.00%> (ø)
...e/kalium/logic/feature/auth/LoginRedirectMapper.kt 25.00% <25.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197a6e9...a14dee2. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 11, 2025

Datadog Report

Branch report: feat/newlogin-loginflow-selectorrefactor
Commit report: 4fae793
Test service: kalium-jvm

✅ 0 Failed, 3329 Passed, 108 Skipped, 1m 3.6s Total Time

@yamilmedina yamilmedina merged commit 872c7a8 into epic/new-sso-login-flow Feb 14, 2025
20 checks passed
@yamilmedina yamilmedina deleted the feat/newlogin-loginflow-selectorrefactor branch February 14, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants