Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort folders by name [WPB-15890] #3284

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 7, 2025

TaskWPB-15890 [Android] Sorting of folders list


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • sorting folders by name

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Results

3 513 tests  ±0   3 405 ✅ ±0   7m 1s ⏱️ + 1m 6s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit 2d2bf1b. ± Comparison against base commit 20791fd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.83%. Comparing base (76d2206) to head (2d2bf1b).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3284      +/-   ##
===========================================
- Coverage    53.90%   50.83%   -3.07%     
===========================================
  Files         1303     1607     +304     
  Lines        37404    58053   +20649     
  Branches      3770     5203    +1433     
===========================================
+ Hits         20162    29512    +9350     
- Misses       15833    26525   +10692     
- Partials      1409     2016     +607     

see 2910 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d2206...2d2bf1b. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/sort-folders-by-name
Commit report: cb94b8c
Test service: kalium-jvm

✅ 0 Failed, 3405 Passed, 108 Skipped, 1m 3.73s Total Time

@Garzas Garzas enabled auto-merge February 7, 2025 12:58
@Garzas Garzas added this pull request to the merge queue Feb 7, 2025
Merged via the queue into develop with commit 8838325 Feb 7, 2025
24 checks passed
@Garzas Garzas deleted the fix/sort-folders-by-name branch February 7, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants