Improve Lua auto splitting runtime #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactored some of the other functions and removed unneeded ones.
Define `process = "{game_name}"` in startup instead of calling
`process()` at the top of the auto splitter.
The auto splitter script will now keep running if the game is closed and
will try and find the new game process before continuing, instead of
running the entire script again from the start.
This stops the user from calling any function, for e.g. 'print', outside of the functions stated in the documentation
It now allows for it to be formatted like
state = {
["AmidEvil-Win64-Shipping"] = {
Start = { 'byte', 0x2BAFFD0 },
Loading = { 'byte', 0x2E76B0C },
MenuStage = { 'byte', 0x2F75F14 },
Paused = { 'byte', 0x2B95A68 },
["Steam"] = {
Start = { 'byte', 0x2BB3470 },
Loading = { 'byte', 0x2B7DDD4 },
MenuStage = { 'byte', 0x2F79424 },
Paused = { 'byte', 0x2B98F08 }
}
}
}
This allows you to set values for when no version is defined, alongside
ones for specific versions
…litters Functions such as 'split' must now be 'Split' Variables such as 'refreshRate' must now be 'RefreshRate' The 'state' table must now be 'State'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes breaking changes to current auto splitters
Functions inside the Lua auto splitters will only run when needed, the same as LiveSplits ASL auto splitters documented here.
Added support for onSplit, onStart and onReset functions to run when split, start and reset return true in the auto splitter.
The game process will now be defined by
process = 'name'inside thestartupfunction, instead of callingprocess('name')at the start of the script.TODO: