Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove shell.nix in favour of flakes #5184

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

pyranota
Copy link
Collaborator

@pyranota pyranota commented Jan 31, 2025

Important

Remove shell.nix and update .envrc to use flake for environment management.

  • Environment Management:
    • Remove shell.nix file, eliminating the previous Nix environment setup.
    • Update .envrc to use flake instead of nix, indicating a switch to Nix Flakes.

This description was created by Ellipsis for d45cbb1. It will automatically update as commits are pushed.

@pyranota pyranota requested a review from rubenfiszel as a code owner January 31, 2025 12:16
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d45cbb1 in 10 seconds

More details
  • Looked at 108 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .envrc:1
  • Draft comment:
    Ensure that all dependencies and configurations are compatible with the use of flakes, as this change might affect how the environment is set up.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from 'use nix' to 'use flake' in .envrc is appropriate given the PR's intent to switch to flakes. However, it's important to ensure that the rest of the environment setup is compatible with this change.

Workflow ID: wflow_7oiKwCLgPcg6CJSJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: d45cbb1
Status: ✅  Deploy successful!
Preview URL: https://bca0b893.windmill.pages.dev
Branch Preview URL: https://use-flake-envrc.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit e41fe92 into main Jan 31, 2025
2 checks passed
@rubenfiszel rubenfiszel deleted the use-flake-envrc branch January 31, 2025 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants