Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove punctuation from question slug #40

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Jan 17, 2024

Remove punctuation from questions slugs apart from hyphens and underscores, as discussed in Textualize/textual#4027

Important

Markdown converters may generate the heading IDs differently as mentioned in the original PR linked above,.

Before ❌

The correct anchor link is: https://textual.textualize.io/FAQ/#why-doesnt-the-datatable-scroll-programmatically

Currently this link is broken in automated responses because the backticks in the title are included in the slug:

why-doesn't-the-`datatable`-scroll-programmatically

After ✅

why-doesnt-the-datatable-scroll-programmatically

@TomJGooding TomJGooding marked this pull request as ready for review January 23, 2024 17:36
@willmcgugan
Copy link
Owner

Thanks

@willmcgugan willmcgugan merged commit bf3f9ef into willmcgugan:main Jan 31, 2024
@TomJGooding TomJGooding deleted the fix-remove-punctuation-from-question-slug branch January 31, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants