removed label props and used absolute import

williaster · Nov 15, 2017 · beaa221 · beaa221
1 parent 6fbc442
commit beaa221
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/packages/demo/examples/01-xy-chart/StatsSeriesExample.jsx b/packages/demo/examples/01-xy-chart/StatsSeriesExample.jsx
@@ -93,7 +93,6 @@ export function SimpleBoxPlotSeriesExample() {
       <YAxis numTicks={4} />
       <BoxPlotSeries
         data={boxPlotData}
-        label="Test"
         fill="url(#aqua_lightaqua_gradient)"
         stroke="#22b8cf"
         strokeWidth={1.5}
@@ -140,7 +139,6 @@ export function SingleBoxPlotSeriesExample() {
       />
       <BoxPlotSeries
         data={boxPlotData}
-        label="Test"
         fill="url(#aqua_lightaqua_gradient)"
         stroke="#22b8cf"
         strokeWidth={1.5}
@@ -192,15 +190,13 @@ export function HorizontalBoxPlotViolinPlotSeriesExample() {
       <YAxis numTicks={4} />
       <ViolinPlotSeries
         data={violinData}
-        label="Test"
         fill="url(#vViolinLines)"
         stroke="#22b8cf"
         strokeWidth={0.5}
         horizontal
       />
       <BoxPlotSeries
         data={boxPlotData}
-        label="Test"
         fill={colors.categories[0]}
         stroke={colors.categories[0]}
         widthRatio={0.5}
@@ -248,14 +244,12 @@ export function BoxPlotViolinPlotSeriesExample() {
       <YAxis numTicks={4} />
       <ViolinPlotSeries
         data={violinData}
-        label="Test"
         fill="url(#hViolinLines)"
         stroke="#22b8cf"
         strokeWidth={0.5}
       />
       <BoxPlotSeries
         data={boxPlotData}
-        label="Test"
         fill={colors.categories[0]}
         stroke={colors.categories[0]}
         widthRatio={0.5}

diff --git a/packages/xy-chart/src/series/BoxPlotSeries.jsx b/packages/xy-chart/src/series/BoxPlotSeries.jsx
@@ -1,7 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Group } from '@vx/group';
-import { BoxPlot } from '@vx/stats';
+import Group from '@vx/group/build/Group';
+import BoxPlot from '@vx/stats/build/boxplot/BoxPlot';
 import themeColors from '@data-ui/theme/build/color';
 
 import { callOrValue, isDefined } from '../utils/chartUtils';
@@ -10,7 +10,6 @@ import { boxPlotSeriesDataShape } from '../utils/propShapes';
 
 const propTypes = {
   data: boxPlotSeriesDataShape.isRequired,
-  label: PropTypes.string.isRequired,
 
   // attributes on data points will override these
   fill: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
@@ -53,7 +52,6 @@ const outliers = d => d.outliers || [];
 
 export default function BoxPlotSeries({
   data,
-  label,
   fill,
   stroke,
   strokeWidth,
@@ -78,7 +76,7 @@ export default function BoxPlotSeries({
      (((1 - widthRatio) / 2) * actualyWidth),
   });
   return (
-    <Group key={label}>
+    <Group>
       {data.map((d, i) => (
         isDefined(min(d)) && (
           <BoxPlot

diff --git a/packages/xy-chart/src/series/ViolinPlotSeries.jsx b/packages/xy-chart/src/series/ViolinPlotSeries.jsx
@@ -1,7 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Group } from '@vx/group';
-import { ViolinPlot } from '@vx/stats';
+import Group from '@vx/group/build/Group';
+import ViolinPlot from '@vx/stats/build/violinplot/ViolinPlot';
 import themeColors from '@data-ui/theme/build/color';
 
 import { callOrValue } from '../utils/chartUtils';
@@ -11,7 +11,6 @@ import { violinPlotSeriesDataShape } from '../utils/propShapes';
 
 const propTypes = {
   data: violinPlotSeriesDataShape.isRequired,
-  label: PropTypes.string.isRequired,
 
   // attributes on data points will override these
   fill: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
@@ -42,7 +41,6 @@ const y = d => d.y;
 
 export default function ViolinPlotSeries({
   data,
-  label,
   fill,
   stroke,
   strokeWidth,
@@ -64,7 +62,7 @@ export default function ViolinPlotSeries({
      (((1 - widthRatio) / 2) * actualyWidth),
   });
   return (
-    <Group key={label}>
+    <Group>
       {data.map((d, i) => (
         <ViolinPlot
           key={offsetValue(d)}