Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate callback type #10

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Validate callback type #10

merged 2 commits into from
Jan 30, 2022

Conversation

abienvenu
Copy link
Contributor

Hello,
I suggest we also validate the type of the callback.
PHP8 will throw a TypeError when one calls explode() for an array instead of a string.

stof
stof reviewed Nov 15, 2021
View reviewed changes
src/JsonpCallbackValidator.php Outdated Show resolved Hide resolved
src/JsonpCallbackValidator.php Show resolved Hide resolved
@willdurand
Copy link
Owner

(rebase + force push to trigger CI)

@willdurand willdurand merged commit 738c36e into willdurand:master Jan 30, 2022
@willdurand
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@willdurand willdurand willdurand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abienvenu @willdurand @stof