Use the UMD build of intl-messageformat in the testsuite #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main file of the library is a CommonJS build, not an UMD build, making it incompatible with the usage in the testsuite setup. The UMD build is shipped in the package but is not exposed on CDNJS.
|
@stof I see the error: Died on test #12 global code@file:///home/runner/work/BazingaJsTranslationBundle/BazingaJsTranslationBundle/Resources/js/translatorTest.js:23:5: Can't find variable: Intl
Can we fix it? |
|
Anyway, i will merge it, since this is an important security fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main file of the library is a CommonJS build, not an UMD build, making it incompatible with the usage in the testsuite setup. The UMD build is shipped in the package but is not exposed on CDNJS.