Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example applications for identity propagation with OIDC #194

Merged

Conversation

fjuma
Copy link
Contributor

@fjuma fjuma commented Nov 13, 2023

No description provided.

Copy link
Contributor

@Skyllarr Skyllarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjuma Just checking, should this example have a simple README ?

@@ -0,0 +1,28 @@
package org.wildfly.security.examples.ejb_basic.ejb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjuma Just a detail, missing copyright here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@@ -0,0 +1,7 @@
package org.wildfly.security.examples.ejb_basic.ejb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjuma Just a detail, missing copyright here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@@ -0,0 +1,27 @@
package org.wildfly.security.examples.ejb_same_domain.ejb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjuma Just a detail, missing copyright here and above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

</auth-constraint>
</security-constraint>

<!-- Configure login to be HTTP Basic -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor, this comment should specify OIDC and not Basic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

@fjuma fjuma force-pushed the oidc-identity-propagation branch from 7dc14ee to c0ceadb Compare November 14, 2023 14:44
@fjuma
Copy link
Contributor Author

fjuma commented Nov 14, 2023

@fjuma Just checking, should this example have a simple README ?

I have a guide in progress so will skip the READMEs for now. All the details will be in the guide. I'll just add a simple README that explains what the example is for, thanks for pointing it out!

@fjuma fjuma force-pushed the oidc-identity-propagation branch from c0ceadb to 0f0e5b3 Compare November 14, 2023 15:53
@fjuma fjuma merged commit 25d799d into wildfly-security-incubator:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants