-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example applications for identity propagation with OIDC #194
Add example applications for identity propagation with OIDC #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjuma Just checking, should this example have a simple README ?
@@ -0,0 +1,28 @@ | |||
package org.wildfly.security.examples.ejb_basic.ejb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjuma Just a detail, missing copyright here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
@@ -0,0 +1,7 @@ | |||
package org.wildfly.security.examples.ejb_basic.ejb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjuma Just a detail, missing copyright here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
@@ -0,0 +1,27 @@ | |||
package org.wildfly.security.examples.ejb_same_domain.ejb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjuma Just a detail, missing copyright here and above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
</auth-constraint> | ||
</security-constraint> | ||
|
||
<!-- Configure login to be HTTP Basic --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor, this comment should specify OIDC and not Basic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed.
7dc14ee
to
c0ceadb
Compare
I have a guide in progress so will skip the READMEs for now. All the details will be in the guide. I'll just add a simple README that explains what the example is for, thanks for pointing it out! |
c0ceadb
to
0f0e5b3
Compare
No description provided.