Use secrecy crate to protect PINs from accidental leaks
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
approved these changes
May 19, 2024
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
wiktor-k
force-pushed
the
wiktor/use-secrecy
branch
from
ce32e1c to
4756c67
Compare
|
Just for the record I think this already improves the status-quo but we could go further and wrap all |
|
Okay, based on the comment by the linked issue private key material is already secret-protected so the PIN is the only thing missing. I'm going to merge this PR and if something else pops-up we can tackle that in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing messages with the debug output appends secret data such as PINs to logs.
I think using
secrecyis an easy way to make it a bit more explicit which data is sensitive and which isn't.Happy to hear your suggestions!