WIP: Add ClientInfo type to ListeningSocket #61
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very much a work-in-progress, and I'm still unsure on a few things - but here goes nothing!
This adds:
type ClientInfo
type parameter toListeningSocket
fn client_info(stream: &Self::Stream) -> io::Result<Self::ClientInfo>
method toListeningSocket
The idea here being that a new
Session
is initialized with information about the connecting client, such as:or on Windows:
Now, for the issues:
ClientInfo
(specific to the Stream type)Alternatively, we can let Agent implementations extract this information from sockets themselves, but this would likely require an
enum
specifying the socket type, so you can consume socket-specific types. Not quite sure what the best option is - would love your thoughts!