-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH agent client with an example #44
Conversation
9ea1135
to
62244c9
Compare
Looks great! I've added a few comments around the error handling (it may be good to expose a clearer error to the consumer, rather than returning |
Great comments about the errors! As I mentioned in the other comment I think this is a bigger problem and we should be migrating away from the Box into maybe a more specific error type... I'll check it out in another PR but I consider it mostly orthogonal to this PR (as it applies to all others too :( ). |
d3a7d18
to
651bbcc
Compare
Looks great to me! The API here (mirroring the agent-side Session) is very clean! |
Fixes: #32 Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Haha, thanks! 😊 It occurred to me that thanks to the trait being the same one can build and agent that simply forwards requests to another agent with relative ease :) I'm going to merge it now to avoid API drift even though I had a couple of tweaks in mind. |
I'm not happy with the API (especially the Client requiring type for thebut overall this works so I'm sharing for any potential feedback :)ListeningSocket
)