Fixup extension serialization #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/session-bind
branch
from
76cd64f to
9244abb
Compare
baloo
commented
Feb 14, 2024
baloo
force-pushed
the
baloo/session-bind
branch
from
9244abb to
dc5946f
Compare
wiktor-k
reviewed
Feb 14, 2024
baloo
force-pushed
the
baloo/session-bind
branch
3 times, most recently
from
57440e6 to
52b944b
Compare
|
Looks great! Just one minor clippy nit and we're good to go! 🚀 |
This fixes wiktor-k#8, which turned out to be incorrect. The `ExtensionContent` object isn't really standard and pretty unexpected. This also includes a sample implementation of a `struct SessionBind` that will serialize and deserialize correctly. Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/session-bind
branch
from
52b944b to
58024c8
Compare
|
Ha, I missed this clippy error. Sorry. |
|
Looks great! Thanks for your time! 🙏 I'll test that tomorrow and if everything works I'll release a new minor release to fix the current broken released state and then... phew... we do the Tokio:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rollback #8, which turned out to be incorrect.
The
ExtensionContentobject isn't really standard and pretty unexpected.This also includes a sample implementation of a
struct SessionBindthat will serialize and deserialize correctly.