Skip to content

Commit

Permalink
test: Enable bootstrap 3.0.3, 3.1, and 3.2 in CI. Passing!
Browse files Browse the repository at this point in the history
The reason we were failing with some minor cosmetic differences is
that the "css" files were generated with a much older version of
Less.js. I've now re-generated them with the reference version of
Less.js 2.x, and low and behold, we fully pass, not even with minor
cosmetic differences in float precision or whitespace.

I regenerated them using Less 2.7 instead of 2.5 because 2.5 was
not compatible with any version of Node.js I could install. It
did not make a difference for the output, and the fact that we're
passing 2.7 already is if anything better than passing 2.5.

While at it, also:
* remove "expected" overrides, since these now unused.
* remove "bootstrap3" fixture, was already unused.
* remove "bootstrap-3.1-sourcemap" fixture, was already unused.

Change-Id: I3aca8b90efdf1791bd84af497ffc39bb44bbc8d8
  • Loading branch information
Krinkle committed Mar 21, 2024
1 parent 51c4f72 commit cc1d291
Show file tree
Hide file tree
Showing 98 changed files with 864 additions and 33,922 deletions.
16 changes: 16 additions & 0 deletions test/Fixtures/bootstrap-3.0.3/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Generated on 15 March 2024.

```
fresh-node20:less.php$ node --version
v20.5.0
fresh-node20:less.php$ node --version
9.8.0
fresh-node20:less.php$ npm install [email protected]
fresh-node20:less.php$ node_modules/.bin/lessc test/Fixtures/bootstrap-3.0.3/less/bootstrap.less > test/Fixtures/bootstrap-3.0.3/css/bootstrap.css
```

<https://github.com/less/less.js/blob/v2.7.3/CHANGELOG.md>
Loading

0 comments on commit cc1d291

Please sign in to comment.