Less_Functions: Fix "Implicit conversion from float to int" on PHP 8.…

…1 warning This could happen when using the `hsv()` Less function. Closes #119. Bug: T383085 Change-Id: Icaeaff167a574f3d335d984c02c4bbe2cdb150f7
wikimedia · Jan 6, 2025 · afdef14 · afdef14
1 parent 2573465
commit afdef14
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/lib/Less/Functions.php b/lib/Less/Functions.php
@@ -105,7 +105,7 @@ public function hsv( $h, $s, $v ) {
 	 * @param float $a
 	 */
 	public function hsva( $h, $s, $v, $a ) {
-		$h = ( ( self::_number( $h ) % 360 ) / 360 ) * 360;
+		$h = ( ( (int)self::_number( $h ) % 360 ) / 360 ) * 360;
 		$s = self::_number( $s );
 		$v = self::_number( $v );
 		$a = self::_number( $a );

diff --git a/test/Fixtures/less.php/css/T383085-float-precision.css b/test/Fixtures/less.php/css/T383085-float-precision.css
@@ -0,0 +1,3 @@
+div {
+  color: #efffde;
+}
diff --git a/test/Fixtures/less.php/less/T383085-float-precision.less b/test/Fixtures/less.php/less/T383085-float-precision.less
@@ -0,0 +1,6 @@
+@a: #EEFFDE;
+@b: hsv(hsvhue(@a), hsvsaturation(@a), hsvvalue(@a));
+
+div {
+  color: @b;
+}