Fix parse error effecting pseudo classes with "when" guards

Bug: T353144 Change-Id: I6654f8b5849b015359cdfad258dcfcf3dd155534
wikimedia · Apr 19, 2024 · 54f213a · 54f213a
1 parent 6034560
commit 54f213a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/Less/Parser.php b/lib/Less/Parser.php
@@ -2372,13 +2372,15 @@ private function parseImportant() {
 	}
 
 	private function parseSub() {
+		$this->save();
 		if ( $this->matchChar( '(' ) ) {
 			$a = $this->parseAddition();
-			if ( $a ) {
-				$this->expectChar( ')' );
-				return new Less_Tree_Expression( [ $a ], true ); // instead of $e->parens = true so the value is cached
+			if ( $a && $this->matchChar( ')' ) ) {
+				$this->forget();
+				return new Less_Tree_Expression( [ $a ], true );
 			}
 		}
+		$this->restore();
 	}
 
 	/**

diff --git a/test/phpunit/FixturesTest.php b/test/phpunit/FixturesTest.php
@@ -25,7 +25,6 @@ class phpunit_FixturesTest extends phpunit_bootstrap {
 			// Temporary disabled
 			'comments2' => true, // T353132
 			'css' => true, // T352911 & T352866
-			'css-guards' => true, // T353144
 			'import' => true, // T353146
 			'import-reference' => true, // T352862
 			'mixin-args' => true, // T352897
@@ -60,7 +59,6 @@ class phpunit_FixturesTest extends phpunit_bootstrap {
 			'import-remote' => true,
 			'import' => true,
 			'css-escapes' => true,
-			'css-guards' => true,
 			'parse-interpolation' => true,
 			'selectors' => true,
 			'property-accessors' => true,