Fix race condition in updater thread. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2025 04:47
… argument to the thread. This also avoids allocating the updater thread object on the heap, by using `std::optional` instead of `std::unique_ptr`. Code simplified: `std::jthread` destructor will stop and join the thread automatically.
…s inside `std::optional::reset()`.
Maschell
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition, where the updater thread was reading
sCheckUpdateThread(and assuming it wasn't null) while it was being assigned in the parent thread. The intended usage forstd::jthreadis for the thread function to receive astd::stop_tokenas the first argument, eliminating the need to reach into thestd::jthreadobject.This also changes
sCheckUpdateThreadtostd::optional, avoiding one extra heap allocation, costing only 8 bytes.There are also some minor cleanup changes I did while I was bored looking for the bug.