feat: deprecate use_thread #949
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Cool, I think in this PR we should also export use_task/task from the solara namespace, and maybe also have wrapper functions in solara.lab.use_task to warn that it's not in lab anymore?
Also, I think the default argument for dependencies for use_task should be None, so that it does not execute by default (this make the default use_task and task more similar)
solara/util.py
Outdated
| def decorator(func): | ||
| @functools.wraps(func) | ||
| def wrapped(*args, **kwargs): | ||
| warnings.simplefilter("always", DeprecationWarning) |
There was a problem hiding this comment.
I don't think we should call this
There was a problem hiding this comment.
The reason this was originally included is that Python doesn't show DeprecationWarnings by default. However, it seems that it is recommended to use FutureWarning for warnings that you want users to see (as per scikit learn), so I made the warning category configurable by default instead.
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
5e49cc6 to
1c1a375
Compare
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
2 times, most recently
from
3cdb9d4 to
03b2dcd
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
1c1a375 to
f16af91
Compare
iisakkirotko
changed the base branch from
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
to
12-23-chore_explicitly_re-export_components
iisakkirotko
force-pushed
the
12-23-chore_explicitly_re-export_components
branch
from
202ce98 to
5b8ba9c
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
f16af91 to
6bfa775
Compare
|
We already do that in |
iisakkirotko
force-pushed
the
12-23-chore_explicitly_re-export_components
branch
from
5b8ba9c to
804d657
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
6bfa775 to
f776b7c
Compare
iisakkirotko
force-pushed
the
12-23-chore_explicitly_re-export_components
branch
from
804d657 to
c457ccb
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
f776b7c to
d77b641
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
d77b641 to
6582fbf
Compare
iisakkirotko
changed the base branch from
12-23-chore_explicitly_re-export_components
to
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Changes to / New Features:
Description of changes
Deprecate
use_threadin favour ofuse_taskandTask.Closes #784