Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cocoapods] Remove module map from compiled classes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fjtrujy
Copy link

@fjtrujy fjtrujy commented Aug 8, 2019

Hello,
In order to solve this warning, I have been forced to create a private and dummy class because otherwise it is not recognized as a module when you try to use it as a dependency.

Thanks

@fjtrujy
Copy link
Author

fjtrujy commented Aug 8, 2019

Remember to push version to Cocoapod, I have bumped the version already xD

@fjtrujy fjtrujy force-pushed the cocoapods branch 3 times, most recently from 1440ab2 to d8ebed3 Compare August 8, 2019 15:04
@wickwirew
Copy link
Owner

Thanks for taking a look at this! Got a chance to try it out. Cocoapods works now, but it looks like the SPM build is broken. Getting this error:

umbrella header 'CRuntime-umbrella.h' not found umbrella header "CRuntime-umbrella.h"

@fjtrujy
Copy link
Author

fjtrujy commented Aug 10, 2019

Sorry, I just tried cocoapods, I will give a try this week to SPM
Thanks!

@arturdev
Copy link

arturdev commented Jan 8, 2020

I think SPM compatibility is not big deal. Having 0 warning is more crucial than supporting multiple package managers...

@fjtrujy
Copy link
Author

fjtrujy commented Jan 9, 2020

Sorry,
I couldn't dedicate time to try in SPM yet, but if you are happy with this you can merge it if you want

@arturdev
Copy link

@wickwirew ?

@wickwirew
Copy link
Owner

Took a look at it tonight and made some progress. I want to remove CRuntime as a dependency and include the header file in Runtime package. Hopefully this should add Carthage support as well. Ill try to finish it up soon but I have a busy few weeks coming up. If someone fixes before I do I'd be happy to merge is as long as it doesn't break anything.

@arturdev
Copy link

@wickwirew do you have any progress on this?

@wickwirew
Copy link
Owner

wickwirew commented Feb 26, 2020

@arturdev Yea. Everything seems to work. CocoaPods has no warnings, and SPM still functions as expected. Here the branch if you want to try it out: no-cruntime

@arturdev
Copy link

@wickwirew that's awesome!
Will it be merged to master soon?

@arturdev
Copy link

arturdev commented Mar 6, 2020

@wickwirew ?

@wickwirew
Copy link
Owner

@arturdev Its merged. Working on a few bug fixes then will do a release

@arturdev
Copy link

@wickwirew Awesome!! Looking forward to the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants