Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite all fields when decoding, even if the value is null #21

Closed
Stebalien opened this issue Jun 19, 2020 · 1 comment · Fixed by #22
Closed

Overwrite all fields when decoding, even if the value is null #21

Stebalien opened this issue Jun 19, 2020 · 1 comment · Fixed by #22

Comments

@Stebalien
Copy link
Collaborator

Currently, if a value is null, we'll won't set the field in the struct to null. This means a re-used object could end up with merged state.
@Stebalien
Copy link
Collaborator Author

Alternatively, we could check to see if the struct is empty and refuse to decode into it if not?

Stebalien added a commit to Stebalien/cbor-gen that referenced this issue Jun 19, 2020
@Stebalien
fix: clear struct state on unmarshal
0d38541 
fixes whyrusleeping#21

We could also make sure every field write writes to the field, no matter what.
However, this is much safer.
Stebalien added a commit to Stebalien/cbor-gen that referenced this issue Jun 19, 2020
@Stebalien
fix: clear struct state on unmarshal
3e7ef1d 
fixes whyrusleeping#21

We could also make sure every field write writes to the field, no matter what.
However, this is much safer.
This was referenced Jun 19, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clear struct state on unmarshal Stebalien/cbor-gen
1 participant
@Stebalien