Skip to content

Commit

Permalink
Remove the TS dependency from the kernel module to the build artifact…
Browse files Browse the repository at this point in the history
… of `@streamlit/lib`
  • Loading branch information
whitphx committed Jan 18, 2024
1 parent 06b09bd commit d293bfc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ $(desktop): packages/desktop/src/*.ts packages/desktop/src/*.tsx packages/deskto

.PHONY: kernel
kernel: $(kernel)
$(kernel): packages/kernel/src/*.ts $(common) $(stlite-server-wheel) $(streamlit_wheel) $(streamlit_proto) $(streamlit_frontend_lib_prod)
$(kernel): packages/kernel/src/*.ts $(common) $(stlite-server-wheel) $(streamlit_wheel) $(streamlit_proto)
cd packages/kernel; \
yarn build
@touch $@
Expand Down Expand Up @@ -132,5 +132,5 @@ $(streamlit_wheel): $(VENV) $(streamlit_proto) streamlit/lib/streamlit/**/*.py s

.PHONY: streamlit-frontend-lib
streamlit-frontend-lib: $(streamlit_frontend_lib_prod)
$(streamlit_frontend_lib_prod): yarn_install $(streamlit_proto) streamlit/frontend/lib/src/**/*.ts streamlit/frontend/lib/src/**/*.tsx streamlit/frontend/lib/package.json streamlit/frontend/lib/tsconfig.json
$(streamlit_frontend_lib_prod): yarn_install $(kernel) $(streamlit_proto) streamlit/frontend/lib/src/**/*.ts streamlit/frontend/lib/src/**/*.tsx streamlit/frontend/lib/package.json streamlit/frontend/lib/tsconfig.json
$(MAKE) -C streamlit frontend-lib-prod
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,12 @@

import type { ReactNode } from "react"

import {
IAllowedMessageOriginsResponse,
BaseUriParts,
SessionInfo,
StreamlitEndpoints,
ensureError,
BackMsg,
ForwardMsg,
} from "@streamlit/lib"
import { IAllowedMessageOriginsResponse } from "@streamlit/lib/src/hostComm/types"
import type { BaseUriParts } from "@streamlit/lib/src/util/UriUtil"
import { SessionInfo } from "@streamlit/lib/src/SessionInfo"
import type { StreamlitEndpoints } from "@streamlit/lib/src/StreamlitEndpoints"
import { BackMsg, ForwardMsg } from "@streamlit/lib/src/proto"
import { ensureError } from "@streamlit/lib/src/util/ErrorHandling"

import { DUMMY_BASE_HOSTNAME, DUMMY_BASE_PORT } from "../../consts"
import { ConnectionState } from "@streamlit/app/src/connection/ConnectionState"
Expand Down

0 comments on commit d293bfc

Please sign in to comment.