-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reply_to is filled if the user is authenticated #290
Conversation
any news about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dethos just to clarify. If I'm filling a box, and am logged in, my e-mail will be used in the reply_to
field? Is that the expected behaviour?
Yes, so the receiver can know who sent it (or to whom he should reply).
I think Hawkpost should give the user the possibility to add this information. So instead of being |
Yes, considering the specific task, I think |
@pjaneiro just made it |
@pjaneiro any news? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge away 👍
Addresses #218
This is a simple implementation of a requested feature. If a user is logged in when submitting a box, the
reply_to
field will be filled with his email address.We could added a field for users not logged in, however we would have to validate the users is not trying to impersonate (not providing is own email address).
A possible improvement for this PR, would be to allow the logged in user to opt out of this feature.
Would that be preferable?