Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for versioned expire timers #268

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

GranPC
Copy link
Contributor

@GranPC GranPC commented Sep 15, 2024

See whisperfish/libsignal-service-rs#321 for more details

NB: my Rust skills compare unfavorably to those of an amoeba, and as such it is entirely possible I have done something horribly wrong.

@gferon gferon enabled auto-merge (squash) September 20, 2024 15:22
@Schmiddiii
Copy link
Contributor

@GranPC Seems like you forgot to update the Cargo.toml to point to the newest commit of libsignal-service-rs, and rebuild presage (to update Cargo.lock).

@GranPC
Copy link
Contributor Author

GranPC commented Sep 23, 2024

@Schmiddiii yeah, that wasn't possible when I originally created the PR because the libsignal-service-rs commit wasn't merged yet. Will get to it in a sec.

auto-merge was automatically disabled September 23, 2024 18:43

Head branch was pushed to by a user without write access

@gferon gferon enabled auto-merge (squash) September 24, 2024 06:31
@gferon gferon disabled auto-merge September 24, 2024 06:31
@gferon gferon force-pushed the jesus/versioned-expiration-timer branch from 90acb12 to 9aaf92c Compare September 24, 2024 06:58
@gferon
Copy link
Collaborator

gferon commented Sep 24, 2024

Thanks a lot for the PR! I introduced a function to make sure the logic is shared when sending both direct and group messages. I also realized there are a bunch of other issues unrelated to your changes: I'm pretty sure we can add a field to the groups_v2::Timer struct of libsignal-service-rs since it has most likely been introduced in the Protobuf messages.

@gferon gferon merged commit 464626a into whisperfish:main Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants