Adjust field in LinkCapabilities struct

[gferon]

This fixes linking.

[rubdos]

Uhh, do we actually implement that capability? 🫣

Maybe it was worth setting it to false? :D

[gferon]

it's hardcoded as true in Signal-Desktop so... 🤷🏻‍♂️

[rubdos]

Yeh okay, probably since SD implements that capability. If we don't make any change, nor we understand what the capability is about, then we might be signing up for a crash-and-burn down the road.

[gferon]

Fair, let me try if it works with false 😄

[rubdos]

Well, if we can just find what this means, and document it, that'd also be fine I suppose :)

[direc85]

I feel the default() is pointless here, we could just document the only place it's used in. And we need to know what the flag means before we set it either way.

[gferon]

I guess it's a matter of taste, I'm not attached to any way of doing it 😄

[gferon]

Well, if we can just find what this means, and document it, that'd also be fine I suppose :)

Can confirm that you cannot link when setting the flag to false.

[direc85]

Just noticed this was merged already. Anyway...

I found out what Signal Android does:

ThreadDelete(
  threadRecipientId = threadRecipient.id.toLong(),
  isFullDelete = isFullDelete,
  messages = messages.map {
    AddressableMessage(
      sentTimestamp = it.dateSent,
      authorRecipientId = it.fromRecipient.id.toLong()
    )
  },
  nonExpiringMessages = nonExpiringMessages.map {
    AddressableMessage(
      sentTimestamp = it.dateSent,
      authorRecipientId = it.fromRecipient.id.toLong()
    )
  }
)

Whisperfish at least already supports individual message deletes, but this feature is about syncing thread deletes i.e. deleting full conversations across devices. That can't be done in libsignal IIUC and so has to be a flag provided by the client and not hardcoded in libsignal-service.

Please change the default to false and provide the API to set the flag. Thanks.

[gferon]

Just noticed this was merged already. Anyway...

I found out what Signal Android does:

ThreadDelete(
  threadRecipientId = threadRecipient.id.toLong(),
  isFullDelete = isFullDelete,
  messages = messages.map {
    AddressableMessage(
      sentTimestamp = it.dateSent,
      authorRecipientId = it.fromRecipient.id.toLong()
    )
  },
  nonExpiringMessages = nonExpiringMessages.map {
    AddressableMessage(
      sentTimestamp = it.dateSent,
      authorRecipientId = it.fromRecipient.id.toLong()
    )
  }
)

Whisperfish at least already supports individual message deletes, but this feature is about syncing thread deletes i.e. deleting full conversations across devices. That can't be done in libsignal IIUC and so has to be a flag provided by the client and not hardcoded in libsignal-service.

Please change the default to false and provide the API to set the flag. Thanks.

false is not an option, since you can't link without it: the support is now mandatory. I find thus the impl Default important.