Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle PNI UUID #299

Merged
merged 23 commits into from
Jul 12, 2024
Merged

Better handle PNI UUID #299

merged 23 commits into from
Jul 12, 2024

Conversation

direc85
Copy link
Contributor

@direc85 direc85 commented May 17, 2024

Try to handle PNI UUID better where ACI UUID is expected.

rubdos
rubdos reviewed May 19, 2024
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to ensure somehow that we can't get the UUID without having checked whether we're at ACI or PNI. Getting this type safe would be ideal.

libsignal-service/src/service_address.rs Outdated Show resolved Hide resolved
@direc85 direc85 force-pushed the handle-pni-uuid branch from 0e8f8e4 to 6a1ef09 Compare May 25, 2024 12:53
rubdos
rubdos reviewed May 27, 2024
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this as close in line with upstream implementations is really mandatory, but I'm not sure how they currently do this. Of course, we also want it as Rusty as possible...

libsignal-service/examples/storage.rs Outdated Show resolved Hide resolved
libsignal-service/src/push_service.rs Outdated Show resolved Hide resolved
libsignal-service/src/service_address.rs Show resolved Hide resolved
libsignal-service/src/service_address.rs Outdated Show resolved Hide resolved
libsignal-service/src/service_address.rs Outdated Show resolved Hide resolved
@direc85 direc85 self-assigned this Jun 24, 2024
@direc85 direc85 marked this pull request as ready for review June 25, 2024 11:29
rubdos
rubdos reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks in a pretty good shape. Some minor things, and then let's get this in.

libsignal-service/src/profile_service.rs Outdated Show resolved Hide resolved
libsignal-service/src/push_service.rs Outdated Show resolved Hide resolved
libsignal-service/src/service_address.rs Show resolved Hide resolved
@rubdos rubdos merged commit 8cd92cd into main Jul 12, 2024
19 checks passed
@rubdos rubdos deleted the handle-pni-uuid branch July 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubdos rubdos rubdos left review comments

@shekohex shekohex shekohex approved these changes

Assignees

@direc85 direc85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@direc85 @rubdos @shekohex