Use YAML 1.2 boolean values for generated log files #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current log files are generated using values that are considered booleans under YAML 1.1, but not YAML 1.2.
This makes the generated logs use the standard boolean values of
true
/false
instead ofYes
/No
so that the logs are parsed the same under both YAML 1.1 and 1.2 into booleans which is going to be less surprising to downstream automated consumers of these logs.The main point of contention I would see is that "Defeat audio cache" was changed from
Unknown
/Yes
/No
tonull
/true
/false
. All of the others were strict booleans (could only be true or false).Example:
This follows from the discussion in #384 around this.