Skip to content

Commit

Permalink
problem: logging unfound node is misleading
Browse files Browse the repository at this point in the history
solution: change 'err' preamble to something less alarming

This is a very common 'error' occurring when a given node is as-of-yet unknown,
and does not necessarily reflect an invalid or otherwise problematic node.

Fixes ethereumproject#308
  • Loading branch information
whilei committed Jul 21, 2017
1 parent db60074 commit a1644fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion p2p/discover/database.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (db *nodeDB) storeInt64(key []byte, n int64) error {
func (db *nodeDB) node(id NodeID) *Node {
blob, err := db.lvl.Get(makeKey(id, nodeDBDiscoverRoot), nil)
if err != nil {
glog.V(logger.Detail).Infof("failed to retrieve node %v: %v", id, err)
glog.V(logger.Detail).Infof("node does not exist in database: %v: %v", id, err)
return nil
}
node := new(Node)
Expand Down

0 comments on commit a1644fa

Please sign in to comment.