Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR changed the setlike add method to return the value that was added to the setlike object instead of the object itself. Was that an accident? #1268

Closed
annevk opened this issue Feb 17, 2023 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Feb 17, 2023

Originally posted by @Liamolucko in #1138 (comment)

cc @tabatkins

@tabatkins
Copy link
Contributor

I think it might have been an accident, yeah. I'll look into it.

@tabatkins
Copy link
Contributor

Ok yup that was clearly a bug on my part. The old spec had add/delete defined in a combined algo, and branched on the operation to figure out what the return value is (the set for add, the value for delete). When I split them apart I must have mistakenly used the same code for each; I probably copy-pasted the algos.

I'll fix in a PR.

tabatkins added a commit to tabatkins/webidl that referenced this issue Feb 21, 2023
tabatkins added a commit to tabatkins/webidl that referenced this issue Feb 28, 2023
@annevk annevk closed this as completed in 8813044 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants