Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dropzone attribute from the specification #2331

Closed
pwnall opened this issue Feb 7, 2017 · 9 comments · Fixed by #2402
Closed

Remove the dropzone attribute from the specification #2331

pwnall opened this issue Feb 7, 2017 · 9 comments · Fixed by #2402
Labels
removal/deprecation Removing or deprecating a feature

Comments

@pwnall
Copy link
Contributor

pwnall commented Feb 7, 2017

The dropzone attribute is not implemented in any browser.

WebKit and Blink have implemented prefixed versions of the attribute, webkitdropzone. I plan to remove the Blink implementation because it hasn't gained much use -- we had a serious bug and it has gone unnoticed for at least a few releases.

In general, I think dropzone is a bit out of place, because it attempts to specify drag-and-drop behavior declaratively, but an application that implements drag-and-drop still needs to use script to handle a drop.

I'm happy to help (e.g., edit the spec and remove WPT files), if this change is agreed upon.
@annevk
Copy link
Member

annevk commented Feb 7, 2017

If it's not implemented in any browser (including nightlies/previews/tip-of-tree), feel free to go ahead with writing tests and proposing an HTML standard change. We should still check with all implementers just in case, but this sounds like a rather safe request.

@domenic
Copy link
Member

domenic commented Feb 7, 2017

I agree this should be pretty safe to remove and it's worth going ahead with a spec and tests PR.

Other browser status:

@domenic domenic added the removal/deprecation Removing or deprecating a feature label Feb 7, 2017
@cdumez
Copy link

cdumez commented Feb 7, 2017

@domenic Asking internally. I'll let you know as soon as I hear back.

@pwnall
Copy link
Contributor Author

pwnall commented Feb 17, 2017

@cdumez 👋 Any news?

@cdumez
Copy link

cdumez commented Feb 17, 2017

@hober update?

@cdumez
Copy link

cdumez commented Feb 17, 2017 •
edited
Loading

Based on the discussion I have seen, I don't believe there is real opposition to dropping it on our side. @hober Please correct me if I am wrong.

@zcorpan
Copy link
Member

zcorpan commented Feb 20, 2017

[blink-dev] Intent to Deprecate and Remove: webkitdropzone global attribute has now been LGTM3-ed.

@foolip
Copy link
Member

foolip commented Feb 21, 2017

Thanks @cdumez! @pwnall, feel free to go ahead and remove this from the spec, and add yourself to https://html.spec.whatwg.org/multipage/acknowledgements.html#acknowledgments while doing so :)

@dstorey dstorey mentioned this issue Feb 21, 2017
Closed
@rniwa rniwa mentioned this issue Feb 22, 2017
Closed
pwnall added a commit to pwnall/html that referenced this issue Feb 25, 2017
@pwnall
Remove the dropzone global attribute.
0b4a708 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

Safari and Chrome implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Chrome [1]. Other browser vendors
have no objections to the attribute getting removed from the spec [2].

[1] https://www.chromestatus.com/feature/5718005866561536
[2] whatwg#2331
@pwnall pwnall mentioned this issue Feb 25, 2017
Merged
pwnall added a commit to pwnall/html that referenced this issue Feb 25, 2017
@pwnall
Remove the dropzone global attribute.
98e05fe 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

Safari and Chrome implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Chrome [1]. Other browser vendors
have no objections to the attribute getting removed from the spec [2].

[1] https://www.chromestatus.com/feature/5718005866561536
[2] whatwg#2331
pwnall added a commit to pwnall/web-platform-tests that referenced this issue Feb 27, 2017
@pwnall
Remove dropzone from DOM tests.
b414f82 
The dropzone attribute is being removed from the HTML specification, per
whatwg/html#2331. This is part of a series of
PRs that aim to remove the attribute from web-platform-tests.
@pwnall pwnall mentioned this issue Feb 27, 2017
Merged
pwnall added a commit to pwnall/html that referenced this issue Feb 28, 2017
@pwnall
Remove the dropzone global attribute.
405fac3 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

Safari and Chrome implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Chrome [1]. Other browser vendors
have no objections to the attribute getting removed from the spec [2].

[1] https://www.chromestatus.com/feature/5718005866561536
[2] whatwg#2331
tkent-google pushed a commit to web-platform-tests/wpt that referenced this issue Feb 28, 2017
@pwnall @tkent-google
Remove dropzone from DOM tests. (#5018)
4e8d373 
The dropzone attribute is being removed from the HTML specification, per
whatwg/html#2331. This is part of a series of
PRs that aim to remove the attribute from web-platform-tests.
pwnall added a commit to pwnall/html that referenced this issue Mar 2, 2017
@pwnall
Remove the dropzone global attribute.
3f9c6d7 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

Safari and Chrome implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Chrome [1]. Other browser vendors
have no objections to the attribute getting removed from the spec [2].

[1] https://www.chromestatus.com/feature/5718005866561536
[2] whatwg#2331
@zcorpan
Copy link
Member

zcorpan commented Mar 3, 2017

Quick check in httparchive

SELECT * FROM (
SELECT page, REGEXP_EXTRACT(LOWER(body), r'(<[a-z][^>]+\s(?:webkit|moz|ms)?dropzone\s*=\s*[^>]+>)') AS match
FROM [httparchive:har.2017_01_15_chrome_requests_bodies]
WHERE page = url
) WHERE match != "null"
Row page match
1 http://www.asbmb.org/ <table width="100%" dropzone="copy">
2 http://www.radware.com/ <table border="0" class="text-center" width="100%" dropzone="copy">
3 http://www.allgov.com/ <div class="grid-12 top-content drop" dropzone="top-content" id="top-content">
4 http://www.itsmarta.com/ <table width="80%" border="0" align="center" cellpadding="4" cellspacing="0" dropzone="copy">
5 http://www.breezecard.com/ <table width="776" dropzone="copy">
6 http://www.scotsmanguide.com/ <table dropzone="copy">
7 http://www.countyofsb.org/ <table dropzone="copy">

Things to note: none of these are using webkitdropzone. None of them seem to actually want a dropzone, but appear to be cargo-culting it and what they actually want is draggable=false on individual links or images inside.

pwnall added a commit to pwnall/html that referenced this issue Mar 6, 2017
@pwnall
Remove the dropzone global attribute.
1d22192 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

Safari and Chrome implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Chrome [1]. Other browser vendors
have no objections to the attribute getting removed from the spec [2].

[1] https://www.chromestatus.com/feature/5718005866561536
[2] whatwg#2331
domenic pushed a commit that referenced this issue Mar 6, 2017
@pwnall @domenic
Remove the dropzone global attribute
3044a7e 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

WebKit and Blink implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Blink [1]. WebKit has no objections
to the attribute getting removed from the spec [2].

Fixes #2331. Tests:

* web-platform-tests/wpt#5052
* web-platform-tests/wpt#5053

[1]: https://www.chromestatus.com/feature/5718005866561536
[2]: #2331 (comment)
@yarini yarini mentioned this issue Apr 26, 2018
Closed
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@pwnall
Remove the dropzone global attribute
4a85dca 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

WebKit and Blink implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Blink [1]. WebKit has no objections
to the attribute getting removed from the spec [2].

Fixes whatwg#2331. Tests:

* web-platform-tests/wpt#5052
* web-platform-tests/wpt#5053

[1]: https://www.chromestatus.com/feature/5718005866561536
[2]: whatwg#2331 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
removal/deprecation Removing or deprecating a feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the dropzone global attribute. pwnall/html
6 participants
@pwnall @zcorpan @foolip @domenic @cdumez @annevk