This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Fix some irregular pluralizations #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, "people" was pluralized to "personople", because submatch 1 was the entier group starting with `(\w*`. Moving the closing bracket to limit submatch 1 seems to avoid this particular issue.
|
I just came across this issue myself with "person" becoming "personople" Sadly, it doesn't look like any action is happening to incorporate this fix. |
|
The author hasn't been on GitHub for more than a year now. Sad that such useful crates kind of get lost. Do other people than @whatisinternet have push access (and publishing rights)? |
|
@mainrs I have a dependency on this crate, so I've forked it and am making updates there. I'll bring in this PR as well as a few others. |
|
@sezna can you share where your fork is? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does:
Fixes the pluralization of "people" to "person" instead of "personople".
Why it does it:
Submatch 1 was the entire group starting with
(\w*and wrapping the whole word. Moving the closing bracket to limit submatch 1 to just the\w*pepart seems to avoid the problem. There might be alternative fixes (get the second group rather than the first in some cases?), but I've tried to patch the problem with minimal changes to avoid causing unrelated bugs.I've also added a few more tests, but I feel like pluralization in particular could use a lot more testing, just in case. It's one of those things that feel like they have a lot of edge cases that might break with changes to the rules.