Weight entry QoL improvements #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment weight by 0.1 and round to one decimal place to prevent floating point accuracy (rounding) issues.
Removed whitespace.
Dieterbe
requested changes
Sep 7, 2024
| @@ -43,7 +43,7 @@ class WeightEntry { | |||
| WeightEntry copyWith({int? id, int? weight, DateTime? date}) => WeightEntry( | |||
| id: id, | |||
| weight: weight ?? this.weight, | |||
| date: date ?? this.date, | |||
| date: date ?? DateTime.now(), | |||
There was a problem hiding this comment.
when you call copyWith(), you expect that it copies the model, and overrides those fields that are given.
therefore this change doesn't make sense. Instead, the callers should just provide whichever date they want to use (DateTime.now())
|
also your PR is a good start, it just needs some tweaks. i will finish it. |
Merged
Dieterbe
closed this pull request by merging all changes
into
wger-project:master
in
96faf89
|
@sizzlesloth thanks! i merged your changes via the PR above. |
|
Thank you very much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (Proposed Changes)
Link to the issue :
Checklist
///).