Skip to content

Commit

Permalink
raidboss: fix misused IN in R4S (OverlayPlugin#346)
Browse files Browse the repository at this point in the history
Response `getIn` refers to dodge a donut-like AOE, not a side cleave.

https://github.com/OverlayPlugin/cactbot/blob/0b794d021c1acc8d6dbe0b067e8dc9ade3bbff47/resources/responses.ts#L434-L435
It is ambiguous here, and `goMiddle` response seems better suit this
situation.

<del>Also fix an i18n issue.</del> Has been fixed by other.
  • Loading branch information
Echoring authored Aug 14, 2024
1 parent 705f145 commit e5afc39
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions ui/raidboss/data/07-dt/raid/r4s.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1196,11 +1196,11 @@ const triggerSet: TriggerSet<Data> = {
response: Responses.goSides(),
},
{
id: 'R4S Wicked Special In',
id: 'R4S Wicked Special Middle',
type: 'StartsUsing',
netRegex: { id: '9612', source: 'Wicked Thunder', capture: false },
condition: (data) => data.secondTwilightCleaveSafe === undefined,
response: Responses.getIn(),
response: Responses.goMiddle(),
},
{
id: 'R4S Aetherial Conversion',
Expand Down Expand Up @@ -1329,19 +1329,19 @@ const triggerSet: TriggerSet<Data> = {
throw new UnreachableCode();

return matches.id === '9610'
? output.combo!({ dir: output[dir]!(), inSides: output.sides!() })
: output.combo!({ dir: output[dir]!(), inSides: output.in!() });
? output.combo!({ dir: output[dir]!(), middleSides: output.sides!() })
: output.combo!({ dir: output[dir]!(), middleSides: output.middle!() });
},
run: (data) => delete data.secondTwilightCleaveSafe,
outputStrings: {
...Directions.outputStringsIntercardDir,
in: Outputs.in,
middle: Outputs.middle,
sides: Outputs.sides,
combo: {
en: '${dir} => ${inSides}',
de: '${dir} => ${inSides}',
ja: '${dir} => ${inSides}',
cn: '${dir} => ${inSides}',
en: '${dir} => ${middleSides}',
de: '${dir} => ${middleSides}',
ja: '${dir} => ${middleSides}',
cn: '${dir} => ${middleSides}',
},
},
},
Expand Down

0 comments on commit e5afc39

Please sign in to comment.