Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple rdns values to prevent duplicate connectors #4405

Closed
wants to merge 1 commit into from

Conversation

starc007
Copy link
Contributor

Support multiple rdns values to prevent duplicate connectors

Description

Modified the rdns property to accept both string and string array values, preventing duplicate MetaMask connectors when using mobile browser.

Changes

  • Updated rdns type to accept string | readonly string[]
  • Modified connector setup to handle multiple rdns values
  • Fixed duplicate MetaMask mobile connector issue (io.metamask.mobile)

Fixes #4404

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 6fb5891

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:58pm

@tmm
Copy link
Member

tmm commented Nov 13, 2024

Made a few changes, but wasn't able to push to your branch so created #4406 (You will still get commit credit!)

@tmm tmm closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out duplicate EIP-6963 providers does not filter out Metamask Mobile
2 participants