Migrate from react-loadable to loadable-component #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, we should remove I can add it or you can do it in this PR? |
|
I let you add it, I've never used errror boundaries |
|
@xD3CODER I've made a PR on your fork, so we can get it into this PR |
Added error boundaries to catch loading errors, updated tests
|
@wellyshen I think this is ready to be merged |
Rid
approved these changes
May 23, 2019
Convert module.exports to export default
Fix error: Warning: Functions are not valid as a React child.
|
@all-contributors please add @xD3CODER for code |
|
I've put up a pull request to add @xD3CODER! 🎉 |
|
@all-contributors please add @Rid for code |
|
I've put up a pull request to add @Rid! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library Loadable-component is recommended as the best alternative of Lazy for SSR.
React-loadable is not maintained for a while.