nextOpeningDates start at and include today #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Following the discovery of a bug in the itemsAPI, we realised there was a mismatch between the content-api's venues response, and the way the itemsAPI was using it, ie. content-api starting the list of openingTimes at today+1 while itemsAPI assuming it started at "today"
https://wellcome.slack.com/archives/C02ANCYL90E/p1714748440989459
It was decided that the content-api should respond with a list of openingTimes that start with "today" if today is an open day
How to test
Running the api locally, hit
http://localhost:3000/venues?title=libraryand check thenextOpeningDatesstart at today if today is an open dayHow can we measure success?
Have we considered potential risks?
ItemsAPI is the only client of this endpoint. There will be checks there and in weco.org before this change is used by live systems