Merge pull request #145 from wellcomecollection/eslint-ignore

Add "ignorePattern" to eslint and add .vscode settings

.eslintrc.js

@@ -52,13 +52,22 @@ const sharedRules = {
   ],
 };
 
+const ignorePatterns = [
+  '/**/node_modules/',
+  '/**/libs/',
+  '/**/lib/',
+  '/**/_next/',
+  '/**/dist/',
+];
+
 module.exports = {
   parser: '@babel/eslint-parser',
   plugins: sharedPlugins,
   env: {
     'jest/globals': true,
   },
   extends: sharedExtends,
+  ignorePatterns,
   rules: sharedRules,
   reportUnusedDisableDirectives: true,
   parserOptions: {
@@ -71,11 +80,11 @@ module.exports = {
     {
       // we have non-test files in the pipeline/test directory
       // this ensures the jest rules only apply to test files
-      files: ['*test.ts', '*test.tsx'],
+      files: ['*test.ts'],
       extends: ['plugin:jest/recommended'],
     },
     {
-      files: ['*.ts', '*.tsx'],
+      files: ['*.ts'],
       parser: '@typescript-eslint/parser',
       plugins: [...sharedPlugins, '@typescript-eslint'],
       extends: [...sharedExtends, 'plugin:@typescript-eslint/recommended'],

.vscode/settings.json

@@ -1,3 +1,12 @@
 {
-  "editor.formatOnSave": true
+  // We add this to avoid having linting commits in CI
+  "editor.tabSize": 2,
+  "files.encoding": "utf8",
+  "editor.codeActionsOnSave": {
+    "editor.insertSpaces": "explicit",
+    "source.fixAll.eslint": "explicit",
+    "source.fixAll.stylelint": "explicit",
+    "files.trimTrailingWhitespace": "explicit"
+  },
+  "stylelint.validate": ["typescriptreact"]
 }

package.json

@@ -17,7 +17,7 @@
   },
   "scripts": {
     "prepare": "husky install",
-    "lint": "eslint \"**/*.{js,ts,tsx}\""
+    "lint": "eslint \"**/*.{js,ts}\""
   },
   "devDependencies": {
     "@babel/eslint-parser": "^7.22.9",