Terraform lambda id_minter and allow deployment #2832
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of: wellcomecollection/platform#5888
Depends on: #2831
This change adds the terraform required to provision the id_minter lambda, and deploy it as part of usual CI.
Note
This change will incorporate testing and replacement of the id_minter, so will remain in draft until this change can be tested as part of the production pipeline and we've confirmed it behaves as expected.
How to test
How can we measure success?
Replacement of the id_minter and reduction in the number of ECS services, simplifying the catalogue pipeline and improving developer experience.
Have we considered potential risks?
If this service does not behave as expected it may cause the production pipeline to temporarily stop processing requests. It contains the same code for creating identifiers, so we should be safe in presuming it will not cause corruption of the id_minter database.
A recent snapshot of the id_minter database is a good mitigation of any risk associated with using this new implementation of the service, so it can be restored in the unlikely event there is an issue.