Allow setting number of worker threads and other HTTP/2 setting params #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
reviewed
Jul 3, 2024
FinleyMcIlwaine
force-pushed
the
finley/145
branch
from
0bf6035 to
38434ba
Compare
We now support setting the `SETTINGS_INITIAL_WINDOW_SIZE` and `SETTINGS_MAX_CONCURRENT_STREAMS` settings via `http2`. We also support setting the initial connection window size, and the number of server worker threads. The default values we set for these help us avoid the window size exhaustion deadlock that resulted in [#168](#168).
FinleyMcIlwaine
force-pushed
the
finley/145
branch
from
38434ba to
82dc724
Compare
FinleyMcIlwaine
force-pushed
the
finley/145
branch
from
3ad1d4f to
59a8650
Compare
edsko
reviewed
Jul 4, 2024
| @@ -41,7 +41,7 @@ data GrpcError = | |||
| -- | Invalid argument | |||
| -- | |||
| -- The client specified an invalid argument. Note that this differs from | |||
| -- 'GrpcFailedPrecondition': 'GrpcInvalidArgumen'` indicates arguments that | |||
There was a problem hiding this comment.
Hah, wow, thanks for catching these!
This just changes code layout, nothing else.
|
Thanks for the update. I've pushed two more commits, one that avoids hardcoding the default of 8 into grapesy by doing instead of having hte figure 8 there (and similarly in other places), and one commit to fix some code layout (long lines). |
|
Although with kazu-yamamoto/http2#130 that "number of workers" might not be relevant at all anymore? I'll verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support setting the
SETTINGS_INITIAL_WINDOW_SIZEandSETTINGS_MAX_CONCURRENT_STREAMSsettings viahttp2. We also support setting the initial connection window size, and the number of server worker threads.The default values we set for these help us avoid the window size exhaustion deadlock that resulted in
#168.
Resolves #145