WELD-2810 Add support for sealed classes to the implementation of CDI Lang Model (+ bump to CDI 5.0) #3122
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit depends on weld/api#225 and again, doesn't necessarily have to be correct. The second commit should be good. |
|
I've sent #3132 to upgrade project version (and similar for API). |
manovotn
changed the title
manovotn
reviewed
Mar 8, 2025
tests-arquillian/src/test/java/org/jboss/weld/tests/extensions/SimpleExtension.java
Show resolved
Hide resolved
manovotn
force-pushed
the
lang-model-sealed-classes
branch
from
90095e7 to
7701c21
Compare
|
I have updated this branch and rebased it onto Though running it locally, I can now see all the tests passing 👍 |
|
You really should feel free to bump to CDI 5.0 API / Weld 7.0 API elsewhere, if that suits you better. The core value of this PR has always been the implementation of the sealed classes support in the lang model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/WELD-2810