Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: At each board, have board-specific roles #1861

Closed
xet7 opened this issue Aug 28, 2018 · 7 comments
Closed

Feature Request: At each board, have board-specific roles #1861

xet7 opened this issue Aug 28, 2018 · 7 comments
Assignees

Comments

@xet7
Copy link
Member

xet7 commented Aug 28, 2018

Roles should have:

  • Role name, example: client
  • Role permission, example: Admin / User / Comment only / No comments
  • Role color, that is round line around the avatar image

For each user on board, when role is selected from list, all role properties are applied.

Only board Admin can change roles.

@xet7 xet7 self-assigned this Aug 28, 2018
@therampagerado
Copy link

Yes, this is a must.

The roles must be editable so everybody can add or remove roles and each action in the kanban should have settings in this area - from moving cards, to deleting lists, boards, etc. At the moment everybody can do virtually everything with the board, deface and ruin the work of many in the company and even stop work at all.

@xet7
Copy link
Member Author

xet7 commented Aug 31, 2018

@rhelsing

In your Comment only permissions PR #925 what does this mean?

models/lists.js:

return allowIsBoardMemberNonComment(userId, Boards.findOne(doc.boardId));
  • What does it do?
  • Did you name it correctly? Or, should is be renamed to something more descriptive?
  • Do you already have permissions for No comments somehow? So for that users comments are not shown?

Some related PRs here:
https://github.com/wekan/wekan/pulls?q=is%3Apr+permission+is%3Aclosed

@rhelsing
Copy link
Contributor

screen shot 2018-08-31 at 8 48 43 am

I believe all references to 'allowIsBoardMemberNonComment' should be changed to 'allowIsBoardMemberNonCommentOnly' to be more descriptive even though that is a bit more verbose. It could be refactored to 'allowIsBoardMemberCommentOnly' to be cleaner descriptively, but that would require more (possibly bug inducing) changes to the codebase. I believe I named it that to be as minimally intrusive as possible to the existing codebase.

@xet7
Copy link
Member Author

xet7 commented Aug 31, 2018

Yes, CommentOnly would be much more descriptive, because current NonComment can be easily confused when I add NoComments. I will look how to make the change.

@xet7
Copy link
Member Author

xet7 commented Aug 31, 2018

Currently at Wekan code, problem is not to do the least intrusive change. More important is to make code clearer and have consistent naming. For example, there is still references to archives in code and database, it should be renamed to recycle bin like it's at translations already.

xet7 added a commit that referenced this issue Sep 4, 2018
  It is like normal user, but does not show comments and activities.

Thanks to xet7 !

Related #1861
xet7 added a commit that referenced this issue Oct 1, 2018
  Docs: https://github.com/wekan/wekan/wiki/REST-API-Role
- OAuth2: Change Oidc preferred_username back to username.

Thanks to xet7 !

Related #1861
xet7 added a commit that referenced this issue Oct 1, 2018
…3caf18).

  [Docs](https://github.com/wekan/wekan/wiki/REST-API-Role). Related to [role issue](#1861).
- OAuth2: [Revert Oidc preferred_username back to username](33caf18).
  This [does not fix or break anything](#1874 (comment)),
  Oidc already works with [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper-provider-app).

Thanks to xet7 !

Related #1861
@xet7
Copy link
Member Author

xet7 commented Apr 12, 2019

Roles for more hidden fields, and add role selection to admin panel #802

@xet7
Copy link
Member Author

xet7 commented Jan 12, 2021

Moved to #3022

@xet7 xet7 closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants